Page 3 of 3

Re: Only one node neighbors node1 ?

PostPosted: Sun Jul 08, 2018 2:43 pm
by Umtauscher
I'm signing off for today,
Nighty night!

Wilhelm

Re: Only one node neighbors node1 ?

PostPosted: Mon Jul 09, 2018 2:23 pm
by DaveL17
So I have found at least one bug in the plugin which could account for some of the confusion. The bug appears in instances where a single device address is shared by multiple Indigo device IDs (think multisensor). For these devices, the neighbor list could be incorrectly set to the last queried device with a valid neighbor list. A little explanation might help get the point across. Think of an Aeon Multisensor with the z-wave address of 2:

Code: Select all
last_good_list = [2, 4, 5, 6, 7]

humidity    id = 12345671 address = 2 neighbors = []
light       id = 12345672 address = 2 neighbors = []
motion      id = 12345673 address = 2 neighbors = [3, 4, 5, 6, 7]
temperature id = 12345674 address = 2 neighbors = []

When iterating through the devices, if the motion device was queried first, the neighbor list would be correct. But in instances where any of the other sub-devices were queried first, the neighbor list would be the same list as the last good list. I'm working on a fix now and taking the opportunity to fix a few other things with the codebase.

Re: Only one node neighbors node1 ?

PostPosted: Mon Jul 09, 2018 2:27 pm
by Umtauscher
Hi Dave,
thanks for letting us know.
Cheers
Wilhelm

Re: Only one node neighbors node1 ?

PostPosted: Tue Jul 17, 2018 6:44 pm
by DaveL17
I have posted an update to the plugin that hopefully addresses all known issues. Of particular note is the improvement to the way that combination devices are handled.

More details are provided here.